Migrate server to ESM #1003
Merged
Migrate server to ESM #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7rulnik
commented
Apr 8, 2024
| @@ -44,7 +44,7 @@ | |||
| "react": "^16.3.0 || ^17.0.0 || ^18.0.0" | |||
| }, | |||
| "dependencies": { | |||
| "@babel/runtime": "^7.7.7", | |||
| "@babel/runtime": "^7.12.18", | |||
There was a problem hiding this comment.
7.12 is the first version that introduces exports field in package.json. We need it for ESM
theKashey
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #999
Right now build process for component and sever is different — component uses rollup and server uses babel. I tried to keep it, but probably the best way in future is migration to rollup.
Test plan
Also I can battle-test it using our project and webpack