Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sync resolution #651

Merged
merged 3 commits into from
Oct 22, 2020
Merged

Fix sync resolution #651

merged 3 commits into from
Oct 22, 2020

Conversation

theKashey
Copy link
Collaborator

loadableReady might resolve when webpack is still running modules stored __LOADABLE_LOADED_CHUNKS__ which will cause too early execution.

Solution: postpone loadableReady to one promise later.

@theKashey theKashey merged commit 1725a62 into master Oct 22, 2020
fivethreeo pushed a commit to fivethreeo/loadable-components that referenced this pull request Nov 16, 2022
@theKashey
Fix sync resolution (gregberge#651)
9b2eb3b 
* chore(tests): make breaking case for webpack4

* fix: loadableReady should not resolve synchronously, fixes gregberge#634

* chore(size): commit size change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@theKashey