fix(color-mode): fix clearing color mode (#385)

styled-components · Oct 5, 2022 · 1bb5cb8 · 1bb5cb8
1 parent 0843917
commit 1bb5cb8
Showing 1 changed file with 6 additions and 14 deletions.
diff --git a/packages/core/src/colorModes.tsx b/packages/core/src/colorModes.tsx
@@ -221,10 +221,13 @@ export function useColorModeState(
   // Add mode className
   const customPropertiesEnabled = checkHasCustomPropertiesEnabled(theme)
 
-  const manualSetRef = React.useRef(false)
   const manuallySetMode = React.useCallback((value: string | null) => {
-    manualSetRef.current = true
-    setMode(value)
+    setMode(value || null)
+    if (value) {
+      storage.set(value)
+    } else {
+      storage.clear()
+    }
   }, [])
 
   // Set initial color mode in lazy
@@ -237,17 +240,6 @@ export function useColorModeState(
     }
   }, [])
 
-  // Store mode preference
-  useIsomorphicLayoutEffect(() => {
-    if (manualSetRef.current) {
-      if (mode) {
-        storage.set(mode)
-      } else {
-        storage.clear()
-      }
-    }
-  }, [mode])
-
   // Sync system mode
   useIsomorphicLayoutEffect(() => {
     const storedMode = storage.get()