Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the "spaces" property bag in "texts" #350

Closed
quantizor opened this issue Feb 3, 2022 · 0 comments · Fixed by #351
Closed

Include the "spaces" property bag in "texts" #350

quantizor opened this issue Feb 3, 2022 · 0 comments · Fixed by #351

Comments

@quantizor
Copy link
Collaborator

Currently definitions inside the "texts" theme key allows for customization of multiple properties at once, which is great. The only issue is it doesn't also allow settings things like marginBottom which is a common need for things like headings.
@quantizor quantizor changed the title Allow any system property + value pairing in "texts" Include the "spaces" property bag in "texts" Feb 3, 2022
quantizor added a commit to quantizor/xstyled that referenced this issue Feb 3, 2022
@quantizor
feat: add ability to customize spacing properties in "texts"
95b4048 
Fixes styled-components#350
@quantizor quantizor mentioned this issue Feb 3, 2022
Merged
gregberge pushed a commit that referenced this issue Apr 2, 2022
@quantizor
feat: add ability to customize spacing properties in "texts" (#351)
57304c2 
Fixes #350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add ability to customize spacing properties in "texts" quantizor/xstyled
1 participant
@quantizor