Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pixel selection zoom bug #10

Open
gregjohnson2017 opened this issue Mar 22, 2020 · 2 comments
Open

Pixel selection zoom bug #10

gregjohnson2017 opened this issue Mar 22, 2020 · 2 comments
Assignees
@gregjohnson2017
Labels
bug Something isn't working

Comments

@gregjohnson2017
Copy link
Owner

Zooming in too far in larger images (correlation between larger images and how far you need to zoom in to observe the bug) makes selection outlines go haywire (also appears to be pixel misaligned too)
@kroppt kroppt added the bug Something isn't working label Mar 22, 2020
@gregjohnson2017
Copy link
Owner Author

Example of outline pixel-misalignment
image

@gregjohnson2017 gregjohnson2017 self-assigned this Mar 30, 2020
@gregjohnson2017
Copy link
Owner Author

The source of the problem has been identified as the gl.Viewport exceeding the +/- 16k coordinate limit. This idea was an optimization to make the calculated line coordinates relative to the image so they didn't have to be recalculated every time there is a pan or a zoom. Not sure how to fix this, but this is another reason why we might want to do the selection outline calculations in a shader.

@gregjohnson2017 gregjohnson2017 mentioned this issue Sep 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregjohnson2017 gregjohnson2017

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add selection outline shaders gregjohnson2017/tabula-editor
2 participants
@kroppt @gregjohnson2017