Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection outline edge cases, not appearing #11

Open
gregjohnson2017 opened this issue Mar 22, 2020 · 1 comment
Open

Selection outline edge cases, not appearing #11

gregjohnson2017 opened this issue Mar 22, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@gregjohnson2017
Copy link
Owner

Selection outline not appearing on certain edges of the image (bottom and left?)

@kroppt kroppt added the bug Something isn't working label Mar 22, 2020
@gregjohnson2017 gregjohnson2017 self-assigned this Mar 30, 2020
@gregjohnson2017
Copy link
Owner Author

gregjohnson2017 commented Aug 31, 2020

This bug happens because of our hacky way of making selection outlines more performant. It involves setting the viewport around the image so the coordinates of the lines don't need to be absolute, but rather relative to the image (and this helps because then the line coordinates don't need to be recomputed when the image is panned or zoomed). Because the viewport is tight around the image, and the lines have to be on one side of a texel (can't be sub-pixel), it just so happens to default to bottom and left. This means that on the left-most and bottom-most edges of the image, the viewport cuts off those lines.

Our current redesign might get rid of this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants