Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add format_alt to temperature and remove collapsed #1640

Merged
merged 9 commits into from
Oct 13, 2022
Merged

Add format_alt to temperature and remove collapsed #1640

merged 9 commits into from
Oct 13, 2022

Conversation

madhur
Copy link
Contributor

@madhur madhur commented Oct 13, 2022

Fixes Issue #1639

@madhur madhur mentioned this pull request Oct 13, 2022
Closed
@MaxVerevkin MaxVerevkin linked an issue Oct 13, 2022 that may be closed by this pull request
Why do we need collapse on temperature block? #1639
Closed
MaxVerevkin
MaxVerevkin requested changes Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@MaxVerevkin MaxVerevkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please add a note in the NEWS.md

src/blocks/temperature.rs Outdated Show resolved Hide resolved
src/blocks/temperature.rs Outdated Show resolved Hide resolved
madhur and others added 3 commits October 13, 2022 21:58
@madhur @MaxVerevkin
Update src/blocks/temperature.rs
a1f3ec5 
Co-authored-by: Max Verevkin <34583604+MaxVerevkin@users.noreply.github.com>
@madhur @MaxVerevkin
Update src/blocks/temperature.rs
3dcdb74 
Co-authored-by: Max Verevkin <34583604+MaxVerevkin@users.noreply.github.com>
@madhurgames
Add format_alt to temperature and remove collapsed
c1fc9d2
MaxVerevkin
MaxVerevkin reviewed Oct 13, 2022
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
MaxVerevkin
MaxVerevkin reviewed Oct 13, 2022
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@MaxVerevkin MaxVerevkin merged commit 6782bd7 into greshake:master Oct 13, 2022
@MaxVerevkin
Copy link
Collaborator

Thanks!

@MaxVerevkin MaxVerevkin mentioned this pull request Oct 13, 2022
Open
@MaxVerevkin MaxVerevkin added enhancement breaking Breaking changes labels Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxVerevkin MaxVerevkin MaxVerevkin approved these changes

Assignees
No one assigned
Labels
breaking Breaking changes enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why do we need collapse on temperature block?
3 participants
@madhur @MaxVerevkin @madhurgames