Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in Gridap 0.17 required to implement high level API #8

Open
amartinhuertas opened this issue Feb 5, 2022 · 0 comments
Open

Comments

@amartinhuertas
Copy link
Member

amartinhuertas commented Feb 5, 2022

In this issue I document issues/misc thoughs while exploring the implementation of the high-level API for hybridized solvers. In particular, what I did is to combine the skeleton code proposed here with the developments so far in ExploringGridapHybridization.jl.

Issues/Changes I had to make in Gridap

  • Added type parameter to FacetoFaceGlue. gridap/Gridap.jl@af7d095
  • Gridap.jl v0.17: MultiFieldCellField cannot be currently built out of fields which are defined on different triangulations, i.e., bulk versus skeleton. A check fails here. I commented out the check. See here
  • Generalization of CellQuadrature member variables in Gridap.jl see here
  • [ALREADY REFLECTED in Gridap 0.17.9] Generalization of CellPoint member variables in Gridap.jl see here
  • Discuss overloads of Reindex + VectorBlock see here
  • MultifieldFEComponentBasis assumes (it is hard-coded) that its cell array of arrays of Fields is created out of the result of applying BlockMap to an array of arrays of Fields. This prevents transformations required in Hybrid methods from [c][b] to [c][f][b]. Instead, following that workflow we first transform [c] into [c][f], and then [c][f][b], which is NOT equivalent to [c][b][f]. I converted the inner constructor to an outer constructor as a workaround. see here A more clean solution might be needed here.

Misc ideas

  • I think it would be useful in several contexts to have FaceToCellGlue parameterized by {Df,Dc}, where Df is the topological dimension of the face and Dc the topological dimension of the cell. Would it be also useful for other types of glues, such as, e.g., FaceToFaceGlue ? To-think.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant