Adding cut_facets feature
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into STL_fix recover comments from main branch comment conflicts
Now: cutgeo = cut( [STLCutters(),] model, STLGeometry ) cutfacets = cut_facets( [STLCutters(),] model, STLGeometry ) # Recompute cutfacets = cut_facet(cutgeo) # Save computations aggregate(strategy, cutgeo, [geo, in_or_out] ) # no need for bgfacet_to_inoutcut
momentfiting does not work in simplex bgmeshes gridap/GridapEmbedded.jl#74
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 92.70% 93.16% +0.46%
==========================================
Files 5 5
Lines 3523 3659 +136
==========================================
+ Hits 3266 3409 +143
+ Misses 257 250 -7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
cut_facetsfunctionality with a similar interface toGridapEmbedded.jl; see #22. Thanks, @janmodderman, for the contribution.We highlight the following changes:
GridapEmbeddedclosest_pointfunction from a point (or a list of points) an STL modelcut(STLCutter(),...)more aligned withGridapEmbeddedsubtriangulate()to hold the cut facets data