You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the Feature Request
The Gridcoin net code is relatively old and still uses quite a few global variables. A backport of CConnman could improve this and improve some of the net code.
Hmm. I think we should discuss this as a group. I am not sure I want to travel all of the byways of Bitcoin as they evolved their codebase after the initial commits of major pieces of functionality, such as the connection manager. I would rather jump to the latest code chunk by chunk if we can make that happen. It may not be possible. A quick perusal of the PIVX project seems to indicate that is the approach they took.
Also there are certain things we have ported over that we have changed a bit which surround the net code, such as the ban manager and misbehavior routines, and I am not sure I want to follow the Bitcoin head in every instance. Some of the stuff we did I actually like better.
In general in backports of major pieces, we have backported CURRENT versions of the code, so we skip all of the intervening bugs, etc. (and instead create new backport bugs... :) ).
Yes, you are probably right and it makes more sense to try to update the code directly to the newest version. But if we at least backport the commits that split the code into new files, I think this will make it easier to update since you can selectively update files and the individual change sets will be smaller.
Feature Request
Describe the Feature Request
The Gridcoin net code is relatively old and still uses quite a few global variables. A backport of CConnman could improve this and improve some of the net code.
Describe Preferred Solution
A backport of the following pr bitcoin/bitcoin#8085
Describe Alternatives
Alternatively, we could also try to renew the net code following the plan outlined by PIVX: PIVX-Project/PIVX#1374
The text was updated successfully, but these errors were encountered: