From 08dfe0b8672a4b406b2c919e2d24c48a76d7c740 Mon Sep 17 00:00:00 2001
From: barton26 <barton2526@gmail.com>
Date: Fri, 10 Sep 2021 02:15:36 -0400
Subject: [PATCH] Upstream FIXME

Don't add failed connections to our refcount
---
 src/net.cpp     | 5 ++---
 src/rpc/net.cpp | 1 -
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/net.cpp b/src/net.cpp
index 9cd8a95499..859b32e627 100644
--- a/src/net.cpp
+++ b/src/net.cpp
@@ -371,9 +371,8 @@ CNode* ConnectNode(CAddress addrConnect, const char *pszDest)
         CNode* pnode = FindNode(static_cast<CService>(addrConnect));
         if (pnode)
         {
-            LogPrintf("Failed to open new connection, already connected FIXME\n");
-            pnode->AddRef();
-            return pnode;
+            LogPrintf("Failed to open new connection, already connected\n");
+            return nullptr;
         }
     }
 
diff --git a/src/rpc/net.cpp b/src/rpc/net.cpp
index 65925d47d9..0a9a8f20ba 100644
--- a/src/rpc/net.cpp
+++ b/src/rpc/net.cpp
@@ -47,7 +47,6 @@ UniValue addnode(const UniValue& params, bool fHelp)
         CNode* pnode= ConnectNode(addr, strNode.c_str());
         if(!pnode)
             throw JSONRPCError(-23, "Error: Node connection failed");
-        //FIXME: should not the connection be release()d?
         UniValue result(UniValue::VOBJ);
         result.pushKV("result", "ok");
         return result;