Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages on termpage template modals could be more specific #75

Open
gridhead opened this issue Mar 10, 2021 · 4 comments
Open

Error messages on termpage template modals could be more specific #75

gridhead opened this issue Mar 10, 2021 · 4 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@gridhead
Copy link
Owner

The error message on the modal shows the same error for invalid console-container attachment termsocket URI, even when that is not the case and actually, the container is just in the EXITED state. The messages could be made more specific to let know the user about the exact nuances behind the failure to attach a console.

Here's a screenshot.

image

@gridhead gridhead added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Mar 10, 2021
@sachindavra
Copy link
Contributor

Hello, What should be done in this case to solve this?

@gridhead
Copy link
Owner Author

Hi @sachindavra,

There are two cases in which, an attempt to attach a termsocket to a container, may potentially fail.

  1. First, if a termsocket is attempted to be attached to a container that is not in a RUNNING state, the container cannot be interacted with and hence, a TTY webconsole cannot be generated.
  2. Second, if a termsocket is attempted to be attached to a container that does not exist, the container cannot be interacted with as it is non-existent and hence, a TTY webconsole cannot be generated.

The above modal shows an ERRONEOUS state to the user but is general for both of the above circumstances while we are looking for different error modals for different cause of failures.

@sachindavra
Copy link
Contributor

Hi @t0xic0der,

This seems related to Docker. I am in the initial phase of learning Docker. May be i can contribute later when i learn something about it. Sorry to bother you.
I thought it's a python coding task.

@gridhead
Copy link
Owner Author

Not a problem.

Feel free to look for other issues that might be right up your alley.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants