Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finalize covering of AlterEventDataEventTest #26

Open
WengerK opened this issue Nov 29, 2018 · 0 comments
Open

finalize covering of AlterEventDataEventTest #26

WengerK opened this issue Nov 29, 2018 · 0 comments
Labels
enhancement New feature or request phpunit

Comments

@WengerK
Copy link
Collaborator

WengerK commented Nov 29, 2018

There is @todo on this code for following cases:

      // @todo add product impression example.
      'Product impressions' => [
        [
          'event' => EventTrackerService::EVENT_PRODUCT_IMPRESSIONS,
          'ecommerce' => [],
        ],
      ],

      // @todo add product click example.
      'Product click' => [
        [
          'event' => EventTrackerService::EVENT_PRODUCT_CLICK,
          'ecommerce' => [],
        ],
      ],

      // @todo add checkout option example.
      'Checkout option' => [
        [
          'event' => EventTrackerService::EVENT_CHECKOUT_OPTION,
          'ecommerce' => [],
        ],
      ],
@WengerK WengerK added enhancement New feature or request phpunit good first issue Good for newcomers and removed phpunit good first issue Good for newcomers labels Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request phpunit
Projects
None yet
Development

No branches or pull requests

1 participant