Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health check endpoint #2302

Closed
brumhard opened this issue Aug 23, 2021 · 4 comments · Fixed by #2319
Closed

Health check endpoint #2302

brumhard opened this issue Aug 23, 2021 · 4 comments · Fixed by #2319

Comments

@brumhard
Copy link
Contributor

📚 Documentation

It would be great to add further documentation to https://grpc-ecosystem.github.io/grpc-gateway/docs/operations/health_check/ and add the example discussed in #1977.

Furthermore the combination of both would be nice to have one http endpoint on the gateway that calls the check method on the grpc server to really have a meaningful result for the health of the whole service.

If possible it would also be nice if it could be added to the options in runtime.NewServeMux like WithHealthCheckEnabled(conn *grpc.ClientConn), to activate a "healthz" route with the described behaviour. I would guess that the need for healthchecks should be common enough for that.
If you think it shouldn't be integrated in this place, maybe there's also another place where this could fit in.

@johanbrandhorst
Copy link
Collaborator

Sounds great, would you be willing to help contribute this?

@brumhard
Copy link
Contributor Author

Sure I'll be happy to look into this 👍

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 9, 2022
@brumhard
Copy link
Contributor Author

Just like PR still stuck in bureaucracy...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants