Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change some RequestStream.WriteAsync errors to match Grpc.Core #1199

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Change some RequestStream.WriteAsync errors to match Grpc.Core #1199

merged 1 commit into from
Feb 9, 2021

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Feb 9, 2021 •
edited
Loading

  • WriteAsync will throw RpcException with status of OK if response has been returned.
  • WriteAsync will only throw InvalidOperationException if CompleteAsync has been called.

@JamesNK JamesNK requested a review from JunTaoLuo February 9, 2021 21:38
@JamesNK JamesNK merged commit 4a8a120 into grpc:master Feb 9, 2021
@JamesNK JamesNK deleted the jamesnk/clientstreaming-writeasync-errors branch February 9, 2021 21:56
@JamesNK JamesNK mentioned this pull request Feb 9, 2021
Merged
6 tasks
@JamesNK JamesNK mentioned this pull request Feb 20, 2021
Closed
This was referenced Mar 18, 2021
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesNK @JunTaoLuo