How to benchmark performance changes

[vaughanr]

Hi,

I've made a small change in my fork to use a local function to avoid an allocation in the GrpcChannel class.

vaughanr@9209782

I think it would but would like to supply hard evidence in the same way that @JamesNK often does in his PRs eg: #775

1. Would you be open to these sorts of PRs with evidence?

2. I assume I should use the Grpc.AspNetCore.Microbenchmarks project. Is there a run option that you always use?

[JamesNK]

The dictionary needs a func so one must be allocated at some point. The current code ensures the func is only allocated once for the channel, rather than every call to GetCachedGrpcMethodInfo. I believe your code change will allocate every call.

Measuring is definitely required whenever making changes for perf.

[vaughanr]

Yes I see that now, thank you for having a look. I saved an allocation on creating a channel but cost one every time it was used! If I attempt one again I will get some evidence before I ask the question.