Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drops by circuit breaking are not reported to LRS #4138

Closed
menghanl opened this issue Jan 7, 2021 · 0 comments · Fixed by #4171
Closed

Drops by circuit breaking are not reported to LRS #4138

menghanl opened this issue Jan 7, 2021 · 0 comments · Fixed by #4171
Assignees
@menghanl
Labels
P1 Type: Bug

Comments

@menghanl
Copy link
Contributor

menghanl commented Jan 7, 2021 •
edited
Loading

The circuit breaking PR missed a feature from the design: https://github.com/grpc/proposal/blob/master/A32-xds-circuit-breaking.md#detailed-design

Such failed calls will not be retried, but they will be recorded to the total_dropped_requests counts in cluster-level load reports and reported to the load reporting server.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@menghanl menghanl

Labels
P1 Type: Bug
Projects
None yet
Milestone
No milestone
2 participants
@menghanl @GarrettGutierrez1