Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport: investigate dynamic buffer sizes for the write buffer #5759

Closed
easwars opened this issue Nov 2, 2022 · 0 comments · Fixed by #6299 or #6309
Closed

transport: investigate dynamic buffer sizes for the write buffer #5759

easwars opened this issue Nov 2, 2022 · 0 comments · Fixed by #6299 or #6309

Comments

@easwars
Copy link
Contributor

easwars commented Nov 2, 2022

This issues addresses bullet point 5 from #5751.

We currently allocate a static buffer which is twice the size configured by the user. This buffer ends up using a bunch of memory, even when not being actively used.

Some options to consider:

  • Dynamically tune buffer size based on activity
  • Use a sync.Pool and keep a bunch of buffers around and manage the number (and possibly size) of these buffers based on activity

We should be able to use the changes made as part of #5757 to test the effectiveness of these options.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants