Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflection depends on a Deprecated Protobuf #6303

Closed
ijrsvt opened this issue May 20, 2023 · 1 comment
Closed

Reflection depends on a Deprecated Protobuf #6303

ijrsvt opened this issue May 20, 2023 · 1 comment
Labels
Type: Feature New features or improvements in behavior

Comments

@ijrsvt
Copy link

ijrsvt commented May 20, 2023

Use case(s) - what problem will this feature solve?

reflection.NewServer generates a server for the v1alpha Reflection client. I would like to use a non-deprecated version of Reflection (v1).

Proposed Solution

Update reflection.NewServer to register both a v1alpha & v1 handler.

Alternatives Considered

Building my own Reflection Server for v1

Additional Context

Deprecation:
https://github.com/grpc/grpc-proto/blob/a0e6d670f8e6357305698fbfd06b4fbcb3b3d63b/grpc/reflection/v1alpha/reflection.proto#L24
@ijrsvt ijrsvt added the Type: Feature New features or improvements in behavior label May 20, 2023
@ijrsvt
Copy link
Author

ijrsvt commented May 22, 2023

Duplicate of #5684

@ijrsvt ijrsvt closed this as completed May 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ijrsvt