From 8808d63338a9374b225113c73ff62e84e203ab48 Mon Sep 17 00:00:00 2001
From: Eric Anderson <ejona@google.com>
Date: Tue, 7 May 2024 11:42:57 -0700
Subject: [PATCH] opentelemetry: Missing locality should be empty string

From gRFC A78:

> If no locality information is available, the label will be set to the
> empty string.
---
 .../java/io/grpc/opentelemetry/OpenTelemetryMetricsModule.java  | 2 +-
 .../io/grpc/opentelemetry/OpenTelemetryMetricsModuleTest.java   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/opentelemetry/src/main/java/io/grpc/opentelemetry/OpenTelemetryMetricsModule.java b/opentelemetry/src/main/java/io/grpc/opentelemetry/OpenTelemetryMetricsModule.java
index 71562c11a46..c93e5a10ad2 100644
--- a/opentelemetry/src/main/java/io/grpc/opentelemetry/OpenTelemetryMetricsModule.java
+++ b/opentelemetry/src/main/java/io/grpc/opentelemetry/OpenTelemetryMetricsModule.java
@@ -213,7 +213,7 @@ void recordFinishedAttempt() {
       if (module.localityEnabled) {
         String savedLocality = locality;
         if (savedLocality == null) {
-          savedLocality = "unknown";
+          savedLocality = "";
         }
         builder.put(LOCALITY_KEY, savedLocality);
       }
diff --git a/opentelemetry/src/test/java/io/grpc/opentelemetry/OpenTelemetryMetricsModuleTest.java b/opentelemetry/src/test/java/io/grpc/opentelemetry/OpenTelemetryMetricsModuleTest.java
index 91b8f43e7ad..6c04c4f0da3 100644
--- a/opentelemetry/src/test/java/io/grpc/opentelemetry/OpenTelemetryMetricsModuleTest.java
+++ b/opentelemetry/src/test/java/io/grpc/opentelemetry/OpenTelemetryMetricsModuleTest.java
@@ -974,7 +974,7 @@ public void clientLocalityMetrics_missing() {
 
     io.opentelemetry.api.common.Attributes clientAttributesWithLocality
         = clientAttributes.toBuilder()
-        .put(LOCALITY_KEY, "unknown")
+        .put(LOCALITY_KEY, "")
         .build();
 
     assertThat(openTelemetryTesting.getMetrics())