Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A failing test deletes Messages.java #1226

Closed
carl-mastrangelo opened this issue Nov 23, 2015 · 2 comments
Closed

A failing test deletes Messages.java #1226

carl-mastrangelo opened this issue Nov 23, 2015 · 2 comments
Milestone
0.14.0

Comments

@carl-mastrangelo
Copy link
Contributor

When running ./gradlew build, if a test fails part way through protobuf-nano/src/generated/test/javanano/io/grpc/protobuf/nano/Messages.java is deleted. This causes noise when running git status or other git commands.
@ejona86
Copy link
Member

ejona86 commented Nov 23, 2015

Yeah. It's caused by the goo we're doing to clean up previously-generated code before regenerating.

I think using google/protobuf-gradle-plugin#33 is the solution, but that isn't implemented.

@ejona86 ejona86 added this to the Unscheduled milestone Dec 1, 2015
@ejona86 ejona86 mentioned this issue Apr 19, 2016
Merged
@ejona86
Copy link
Member

ejona86 commented Apr 19, 2016

Fixed by #1691

@ejona86 ejona86 closed this as completed Apr 19, 2016
@ejona86 ejona86 modified the milestones: 0.14.0, Unscheduled Apr 19, 2016
@hsaliak hsaliak reopened this Apr 2, 2018
@hsaliak hsaliak closed this as completed Apr 2, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
3 participants
@hsaliak @ejona86 @carl-mastrangelo