Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-java fails to build against protobuf 3.21 #9220

Closed
jvolkman opened this issue May 26, 2022 · 1 comment · Fixed by #9218
Closed

grpc-java fails to build against protobuf 3.21 #9220

jvolkman opened this issue May 26, 2022 · 1 comment · Fixed by #9218
Milestone

Comments

@jvolkman
Copy link
Contributor

What version of gRPC-Java are you using?

1.46.0

What is your environment?

Linux, Macos, protobuf v3.21

What did you expect to see?

A successful build

What did you see instead?

grpc-java fails to build:

external/io_grpc_grpc_java/compiler/src/java_plugin/cpp/java_generator.cpp:25:10: fatal error: 'google/protobuf/compiler/java/java_names.h' file not found
#include <google/protobuf/compiler/java/java_names.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Steps to reproduce the bug

Attempt to build grpc-java against protobuf 3.21

This commit in upstream protobuf renamed java_names.h to names.h, which is included by compiler/src/java_plugin/cpp/java_generator.cpp

@YifeiZhuang
Copy link
Contributor

protobuf needs upgrade, currently it is 3.19.2

@YifeiZhuang YifeiZhuang added this to the Next milestone May 27, 2022
@ejona86 ejona86 modified the milestones: Next, 1.48 Jun 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants