Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netty: improve server handling of writes to reset streams #10258

Merged
merged 4 commits into from
Feb 16, 2024

Commits on Jun 8, 2023

  1. netty: improve server handling of writes to reset streams

    A server stream can be reset by the client while server writes are still queued. After the stream is reset, the netty connection will forget the stream object. The `NettyServerHandler` must deal with that situation. `sendResponseHandlers` already had some code to do that. This change standardizes that code and adds it to `sendGrpcFrame`. This fixes a potential bug where a `SendGrpcFrameCommand` with `endOfStream=true` would raise an `AssertionError` if written to a reset stream. (This bug is not currently reachable because `endOfStream=false` for all server `SendGrpcFrameCommand` objects.)
    benjaminp committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    ebecffe View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Configuration menu
    Copy the full SHA
    05a877d View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Configuration menu
    Copy the full SHA
    151efeb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ff55a89 View commit details
    Browse the repository at this point in the history