grpc-js: Loosen requirements on channel option types #1916
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original reason for having this requirement in the old library was for compatibility with the corresponding core type. That got carried over, but there's no real reason now to keep enforcing it, and the presence of this requirement creates a restriction that is unusual in JavaScript that prevents a wrapping library from blindly passing along an options object so that the lower-level library can simply use any options that it considers relevant. In fact, gRPC channel options are already deliberately namespaced, which makes blindly passing options even more reasonable.
In short, I want to eliminate the need for code like in googleapis/gax-nodejs#1115