Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with jakarta 3 dependencies #165

Closed
amseager opened this issue Aug 10, 2021 · 2 comments · Fixed by #166
Closed

Problems with jakarta 3 dependencies #165

amseager opened this issue Aug 10, 2021 · 2 comments · Fixed by #166

Comments

@amseager
Copy link
Contributor

amseager commented Aug 10, 2021

Jakarta 3 brings us a new package structure replacing javax.* with jakarta.*.
As I understand it, in transaction-outbox project, this migration had happened while hibernate validator was updated from 6 to 7. So now, we have a lot of jakarta.* imports across the project. This causes a lot of troubles because a vast majority of libraries and frameworks (e.g. the newest spring boot) still use jakarta 2 with javax.* imports, so you need to use an older version of transaction-outbox in this case to make the code compile.
Is it possible to do something with it? We can downgrade hibernate validator or keep two versions of transaction-outbox? Or even refactor classes with potential problems to make them independent from it.

@badgerwithagun
Copy link
Member

We've been hit with this at Goji too and are frozen on an earlier version.

It's actually looking like a mistake to have taken this hibernate-validator update into the project. I am tempted to revert the related commits in master and jump up a major version of transaction-outbox.

Happy to take a PR , but if not I'll probably do this in the next few weeks.

@badgerwithagun
Copy link
Member

In the meantime, the 2.x branch is active for fixes and we are publishing new versions of 2.x. just not bumping dependences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants