Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TransactionOutbox#scheduler ThreadFactory customization #688

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow TransactionOutbox#scheduler ThreadFactory customization #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions transactionoutbox-core/src/main/java/com/gruelbox/transactionoutbox/TransactionOutbox.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import java.time.Clock;
import java.time.Duration;
import java.util.concurrent.Executor;
import java.util.concurrent.ThreadFactory;
import java.util.function.Supplier;
import lombok.ToString;
import org.slf4j.MDC;
Expand Down Expand Up @@ -152,6 +153,7 @@ abstract class TransactionOutboxBuilder {
protected Boolean serializeMdc;
protected Duration retentionThreshold;
protected Boolean initializeImmediately;
protected ThreadFactory schedulerThreadFactory;

protected TransactionOutboxBuilder() {}

Expand Down Expand Up @@ -298,6 +300,15 @@ public TransactionOutboxBuilder initializeImmediately(boolean initializeImmediat
return this;
}

/**
* @param schedulerThreadFactory The {@link ThreadFactory} that will be used to build the scheduler executor.
* @return Builder.
*/
public TransactionOutboxBuilder schedulerThreadFactory(ThreadFactory schedulerThreadFactory) {
this.schedulerThreadFactory = schedulerThreadFactory;
return this;
}

/**
* Creates and initialises the {@link TransactionOutbox}.
*
Expand Down
5 changes: 3 additions & 2 deletions ...actionoutbox-core/src/main/java/com/gruelbox/transactionoutbox/TransactionOutboxImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ final class TransactionOutboxImpl implements TransactionOutbox, Validatable {
private final Duration retentionThreshold;
private final AtomicBoolean initialized = new AtomicBoolean();
private final ProxyFactory proxyFactory = new ProxyFactory();
private final ScheduledExecutorService scheduler = Executors.newSingleThreadScheduledExecutor();
private final ScheduledExecutorService scheduler;

@Override
public void validate(Validator validator) {
Expand Down Expand Up @@ -435,7 +435,8 @@ public TransactionOutboxImpl build() {
Utils.firstNonNull(listener, () -> TransactionOutboxListener.EMPTY),
serializeMdc == null || serializeMdc,
validator,
retentionThreshold == null ? Duration.ofDays(7) : retentionThreshold);
retentionThreshold == null ? Duration.ofDays(7) : retentionThreshold,
schedulerThreadFactory == null? Executors.newSingleThreadScheduledExecutor() : Executors.newSingleThreadScheduledExecutor(schedulerThreadFactory));
validator.validate(impl);
if (initializeImmediately == null || initializeImmediately) {
impl.initialize();
Expand Down