-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL's missing a scheme fail silently #112
Comments
This admittedly head scratching behavior occurs because it's ambiguous whether See Issue #85 and my detailed answer therein here #85 (comment). Also Issue I will forfend this issue in the future with TLD support, so furl will be able Does that answer your question? |
Ah yes, that does explain the behavior. Is there a way to currently force furl to interpret as a domain if it's missing the delimiters? I'm using furl to parse URLs I'm scraping, and some of them have schemes, while some of them don't. Currently I've fixed this by just prepending "http://" to URLs missing "://" but that doesn't seem to be terribly robust. |
Hi, I am thinking that can we add is_domain in init of |
|
This issue is married to the resolution of #110 |
If I create a furl object without a scheme like so:
It fails in weird ways that aren't exactly intuitive.
I would expect that furl should either raise an error here or create a URL without a scheme.
Instead I get weird results like:
The text was updated successfully, but these errors were encountered: