Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a scheme to a url without scheme results in wrong url #117

Closed
shashankkr9 opened this issue Jun 27, 2019 · 3 comments
Closed

Adding a scheme to a url without scheme results in wrong url #117

shashankkr9 opened this issue Jun 27, 2019 · 3 comments

Comments

@shashankkr9
Copy link

shashankkr9 commented Jun 27, 2019

Example:

url = "google.com"
furled_url = furl(url)
furled_url.scheme = furled_url.scheme or "https"
normalized_url = furled_url.url

# normalized_url is https:///google.com instead of http://google.com
@gruns
Copy link
Owner

gruns commented Jun 28, 2019

While initially a head scratcher, this is actually expected behavior. See #103 (comment) and #106 (comment).

This will be resolved with the addition of #110.

Does the aforementioned answer your question?

@gruns
Copy link
Owner

gruns commented Jan 5, 2020

@shashank-iitj: Little bump -- while initially a bit confusing, do the aforementioned issues and discussion clear things up?

For now, at least, until #110 is implemented.

@gruns
Copy link
Owner

gruns commented Aug 17, 2021

closing this pending #110's implementation

@gruns gruns closed this as completed Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants