Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems to be a bug when paring multiple '@'s ? #163

Open
YuanchengJiang opened this issue Sep 20, 2022 · 0 comments
Open

Seems to be a bug when paring multiple '@'s ? #163

YuanchengJiang opened this issue Sep 20, 2022 · 0 comments

Comments

@YuanchengJiang
Copy link

Hi,

I notice one difference by applying differential testing with urllib.parse.

Case 1:

URL = "https://@david:passwd@testing.xyz"
f = furl(URL)

Error: ValueError: Invalid port 'passwd@testing.xyz'. However, it should access the host 'testing.xyz' with username '@david' and password 'passwd'.

Case 2:

URL = "https://aa@bb@testing.xyz"
f = furl(URL)

Error: ValueError: Invalid host 'bb@testing.xyz'. However, it should access the host 'testing.xyz' with username 'aa@bb'.

When parsing multiple '@'s, I think the domain should be sliced by the last '@' rather than the first '@'.

Thanks,
Yuancheng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant