Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-http2 is deprecated. Use node's built in http2 #270

Closed
darcyparker opened this issue Aug 24, 2021 · 6 comments · Fixed by #289
Closed

node-http2 is deprecated. Use node's built in http2 #270

darcyparker opened this issue Aug 24, 2021 · 6 comments · Fixed by #289

Comments

@darcyparker
Copy link

https://www.npmjs.com/package/node-http2 points to https://github.com/kaazing/node-http2 which no long exists.

It originally forked https://github.com/molnarg/node-http2, which notes that as of Node v9, the built in http2 can be used.

@darcyparker
Copy link
Author

Looks like this is a duplicate of #268, but it is not obvious by the title.

@pedrosanta
Copy link

pedrosanta commented Sep 8, 2021

Looks like this is a duplicate of #268, but it is not obvious by the title.

Yhea @darcyparker, the issue started as the vulnerability report and then shifted focus. This line of action is more succinct. I'll close that one and let's join efforts on this one.

Checking #268 for context about the vulnerability and possible lines of action is still worthwhile, namely my comment here: #268 (comment)

@pedrosanta
Copy link

pedrosanta commented Sep 8, 2021

Also, as I state on my comment (#268 (comment)) updating to node http2 requires a new major version (it's a breaking change on the engine supported versions).

@pedrosanta
Copy link

@Krinkle Hello, with the 4.0.0 release and the Node engines/version update (>=16), maybe we can consider, revisit this?

@Krinkle
Copy link
Contributor

Krinkle commented Aug 8, 2023

@pedrosanta Yes! I don't use the http2 feature myself, but I'd be open to reviewing a pull request if you've got something in mind.

@pedrosanta
Copy link

Sure, will post one then, whenever I can. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants