Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use better log formatting #30

Closed
josh-padnick opened this issue Nov 14, 2017 · 1 comment
Closed

Use better log formatting #30

josh-padnick opened this issue Nov 14, 2017 · 1 comment
Labels
enhancement New feature or request

Comments

@josh-padnick
Copy link
Contributor

I was debugging an issue in a call to gruntwork-install, and my underlying issue was actually with the command I passed to fetch. But the logs output by fetch don't make it obvious that it's fetch throwing the error. Here's an example:

    ubuntu-ami: 2017-11-14 20:47:53 [INFO] [gruntwork-install] Success!
    ubuntu-ami: 2017-11-14 20:47:53 [INFO] [gruntwork-install] Installing from install-kafka...
    ubuntu-ami: 2017-11-14 20:47:53 [INFO] [gruntwork-install] Downloading module install-kafka from https://github.com/gruntwork-io/package-kafka
    ubuntu-ami: ERROR: You must specify exactly one of --tag, --commit, or --branch. Run "fetch --help" for full usage info.

The statement Run "fetch --help" for full usage info. is an indicator this is a fetch error, but the log message should be prefixed with the fetch name, as gruntwork-install logs are in the example above.

@josh-padnick josh-padnick added enhancement New feature or request help wanted labels Nov 14, 2017
@robmorgan
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants