Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .GlobalEnv search in mlg.filter methods #206

Closed
zkamvar opened this issue Jun 15, 2019 · 0 comments
Closed

Remove .GlobalEnv search in mlg.filter methods #206

zkamvar opened this issue Jun 15, 2019 · 0 comments

Comments

@zkamvar
Copy link
Member

zkamvar commented Jun 15, 2019

Currently, mlg.filter will test if a distance or distance function is present in the global environment before proceeding. If not, then it errors. This causes problems with CRAN (see #205)

A better method would be to record the environment for the distance along with the name so that it's possible to just retrieve the distance/function every time without hassle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant