Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored Code #20

Closed
wants to merge 1 commit into from
Closed

Refactored Code #20

wants to merge 1 commit into from

Conversation

Sando1
Copy link

@Sando1 Sando1 commented Oct 31, 2019

Fixes #19

Here's what I did:

  • Moved all .py files to a separate folder.
  • Separated all session, and questions functions. Each has its own class now.
  • Tests have been moved to tests folder
  • .dat files have to moved to static folder
  • Removed redundant code
  • Fixed all file paths
  • Added a requirements.txt file
  • Added an environment.yml

TESTING : THIS CODE HAS NOT BEEN TESTED AS I DON'T HAVE A TOKEN. PLEASE TEST CODE ON VALID TOKEN.

@julianaklulo
Copy link
Contributor

Thanks for your contribution! Sorry it took so long to look into this.

The build failed because the test file was using the method parser_list in the questions_parser.py file, but you moved it to bot/questions.py and changed the method's name to parse_file.

Could you fix the test/test_parser.py file so we can accept your PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor repository
2 participants
@Sando1 @julianaklulo