Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When renaming using lowercase form of the existing note name, the existing file will be overwritten #1695

Closed
sjl872964789 opened this issue May 4, 2022 · 2 comments
Assignees
Milestone

Comments

@sjl872964789
Copy link

sjl872964789 commented May 4, 2022

IMPORTANT

  • App version: 2.8.6
  • Android version/rom: Hydrogen OS
  • Device: OnePlus 8T
  • I accept that this issue will be closed without further notice in case I didn't describe the problem including general information, or didn't search for similar issues & requests.

Explain the Problem

When renaming using lowercase form of the existing note name, the existing file will be overwritten

Steps to Reproduce

Explain what you did to encounter the issue

  1. Create a new note named "Meeting" and record some notes in it
  2. Create a new note named "Date" and record some notes in it
  3. Long press "Meeting"
  4. Click "Rename"
  5. Enter "date"
  6. Click "OK"
  7. The app does not prompt "file already exists", it directly overwrites the original "Date" and its contents

Expected behavior

There should be both "date" and "Date" notes at the same time, or at least there should be a prompt before overwriting the note

Video

20220504-152842.mp4
@gsantner
Copy link
Owner

gsantner commented May 4, 2022 via email

@Twilight-Shuxin
Copy link

Hi, I'm wondering if it would be good to add a warning before overwriting same case-insensitive name files(as same as the files with the exact name). If it is desired, I would be glad to try to add it and make a pull request.

@gsantner gsantner self-assigned this May 21, 2022
@gsantner gsantner added this to the Markor v2.10 milestone May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants