Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when creating new note with zim-wiki-empty.txt template #2340

Closed
4 tasks done
bruvellu opened this issue Jul 5, 2024 · 3 comments · Fixed by #2307
Closed
4 tasks done

Crash when creating new note with zim-wiki-empty.txt template #2340

bruvellu opened this issue Jul 5, 2024 · 3 comments · Fixed by #2307
Assignees
Labels
Milestone

Comments

@bruvellu
Copy link

bruvellu commented Jul 5, 2024

⚠️ This issue respects the following points: ⚠️

  • This is a bug. Not a question or feature request.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)

Description

Since v2.12.1, Markor crashes when trying to create a new note using the zim-wiki-empty.txt template:

photo_2024-07-05_08-34-32

Steps to reproduce

  1. Open Markor and click the red "+"
  2. Select Wikitext / Zim for type and zim-wiki-empty.txt for template
  3. Click OK

Information

Android version: Android 14, One UI 6.1
Device: Samsung Galaxy S24
App Version: v2.12.2 (151)

Source

Google Play

Format / File type

Wikitext, Zim

Additional info / Log

Package: net.gsantner.markor
Version: v2.12.2 (151)
Flavor: Gplay (release)
Build date: 2024-05-25T10:13Z
ISource: Google Play
VCS Hash: a2afb69bc6edcf9ee35d33060a02ae7cc0292847
VCS Msg: Markor v2.12.2 (code 151)
@harshad1
Copy link
Collaborator

harshad1 commented Jul 5, 2024

Fixed in #2037

@gsantner I have one or two changes to push to that PR. I will try to get them in by tonight so we can merge soon. It has gotten quite bloated with a lot of tweaks and fixes

@gsantner
Copy link
Owner

gsantner commented Jul 5, 2024 via email

@bruvellu
Copy link
Author

bruvellu commented Jul 6, 2024

Thanks so much @gsantner and @harshad1! I guess you meant #2307?

@gsantner gsantner linked a pull request Jul 20, 2024 that will close this issue
@gsantner gsantner added the bug label Jul 20, 2024
@gsantner gsantner added this to the Markor v2.13 milestone Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants