New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HashPassword naming confuses people #21

Open

gtank opened this issue Jun 1, 2017 · 3 comments

Owner

gtank commented Jun 1, 2017

No description provided.

stephenmw commented Jun 1, 2017 •

edited

Loading

I recommend NewPasswordHash. Its documentation should state:

This command returns a different hash each call for the same password.
Use CheckPasswordHash to verify a password matches the hash.

Owner Author

gtank commented Jun 1, 2017

Agreed, NewPasswordHash is way better.

FiloSottile commented Jun 1, 2017 via email

To avoid breaking compatibility just leave the old name in, calling the new one, and mark it with the godoc deprecated annotation to hide it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment