Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement NewKeyFromPassword #7

Open
gtank opened this issue Jul 8, 2016 · 2 comments
Open

Implement NewKeyFromPassword #7

gtank opened this issue Jul 8, 2016 · 2 comments

Comments

@gtank
Copy link
Owner

gtank commented Jul 8, 2016

golang.org/x/crypto/scrypt is the right approach, but it introduces some critical questions:

  1. N, r, and p need to be benchmarked on modern systems since the paper is from 2009.
  2. The paper, Go docs, and broader internet lack clear guidance on generation & management of scrypt salts.

Until these are resolved, the package should continue to advise random AES keys.

@titanous
Copy link

titanous commented Jul 16, 2016

This post and its follow-up have some useful recent benchmarks of KDFs: https://pthree.org/2016/06/28/lets-talk-password-hashing/

@jaylams
Copy link

jaylams commented Jul 17, 2016

Interesting benchmarks extensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants