scan_for_focus_path should return an empty array if path is a directory #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I have set `focus_on`, and I run all tests, then a directory path may be sent to Focuser#scan_for_focus_path. This method tries to call File#gets on the path, and ruby throws a "Is a directory" error. This patch simply returns an empty array if the file is a directory.
netzpirat
added a commit
that referenced
this pull request
Jan 7, 2013
scan_for_focus_path should return an empty array if path is a directory
|
Great work, thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I have set the
focus_onoption, and I run all feature tests in cucumber-guard, then a directory path may be sent toFocuser#scan_for_focus_path. This method tries to callFile#getson the directory, and ruby throws a "Is a directory" error.This patch simply returns an empty array if the file is a directory.