Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require Bundler to use binstubs #8

Merged
merged 2 commits into from
Apr 1, 2013
Merged

Conversation

JeanMertz
Copy link

Spring installs binstubs as bin/cucumber with this content:

#!/usr/bin/env bash
exec $(dirname $0)/spring cucumber "$@"

To execute this, I would need to start guard-cucumber with this command:

guard 'cucumber', binstubs: true, bundler: false

However, this was not possible before, because binstubs: true implied bundler: true. I'm sure there is a good reason for this, and feel free to reject this PR, this is just something that works for me, and I expect helps others as well.

@netzpirat
Copy link

That option check was done at the time where binstubs were only provided by Bundler, so I happily merge your pull request if you make the specs pass again :P Thanks a lot!

@JeanMertz
Copy link
Author

@netzpirat I couldn't find this PR's build in Travis (not sure why?) and I am not behind my work machine right now, so I just changed it through the GitHub online editor.

As far as I could tell, the test description actually described something else than the test was doing. It should be green now.

edit: I guess the PR isn't building because Travis is pointing to your account, and not the Guard one.

@netzpirat
Copy link

@JeanMertz Thanks for the update! Release 1.4.0. Yes, the specs are from my early days and a bit awkward, wouldn't do it like that nowadays. Travis is indeed configured on the original repo and not this fork.

@netzpirat netzpirat merged commit 96bbb4e into guard:master Apr 1, 2013
@JeanMertz
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants