Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect exit code for test runner on CI, possible regression #105

Closed
conzett opened this issue Jan 24, 2013 · 3 comments
Closed

Incorrect exit code for test runner on CI, possible regression #105

conzett opened this issue Jan 24, 2013 · 3 comments

Comments

@conzett
Copy link

conzett commented Jan 24, 2013

This might be a regression as I see this had been addressed previously with #33 it looks like this is happening again though (no wonder all my builds were passing!) Travis logs from a recent build:

// snip
22:28:39 - ERROR - 77 specs, 4 failures
22:28:39 - INFO - Done.
22:28:39 - INFO - Guard::Jasmine stops server.
Done. Build script exited with: 0

Currently using master branch of guard-jasmine rather than a specific gem version.

@netzpirat
Copy link
Contributor

Thanks for reporting. I'll have a look at it tomorrow or over the weekend. I anyway want to reflect the coverage status in the CI exit status.

@netzpirat
Copy link
Contributor

The exit status works fine, but the Travis CI configuration examples in the README was wrong. We cannot use after_script for running the Jasmine specs, since that exit code has no influence on the build status. The sultion is simple, just use && to combine the two spec scripts.

@conzett
Copy link
Author

conzett commented Jan 28, 2013

Good call, thanks so much for your help and work on this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants