Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors in javascript code are silently ignored and tests pass. #122

Closed
swistak opened this issue Apr 5, 2013 · 3 comments
Closed

Errors in javascript code are silently ignored and tests pass. #122

swistak opened this issue Apr 5, 2013 · 3 comments

Comments

@swistak
Copy link
Contributor

swistak commented Apr 5, 2013

When runnig a spec suite where javascript causes exception, errors are ignored and spec suite passes correctly.

Example - this code generates exception when used with phantom.js 1.6 (default on Ubuntu 12)

(function foo(){}).bind(this)

Despite this specs pass without any indication what happened.
@swistak
Copy link
Contributor Author

swistak commented Apr 6, 2013

I've done some work towards solution: #123 (I have no fucking idea why gihub does not add ability to attach pull request ot existing issue).

It seems to break shitloads of test though.

@swistak swistak closed this as completed Apr 6, 2013
@rymai
Copy link
Member

rymai commented Apr 6, 2013

You can actually attach a pull-request to an existing issue via the API! Probably easier by using hub.

@richo
Copy link
Contributor

richo commented Apr 6, 2013

http://issue2pr.herokuapp.com

In case you didn't want to install software just to poke at an API ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rymai @swistak @richo