Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error outside of examples is not reflected in notification #398

Open
wnuqui opened this issue Jul 6, 2017 · 0 comments
Open

Error outside of examples is not reflected in notification #398

wnuqui opened this issue Jul 6, 2017 · 0 comments

Comments

@wnuqui
Copy link

wnuqui commented Jul 6, 2017

Steps to recreate

  1. Generate a gem skeleton via bundle. (A simple app with a Gemfile is also usable but you need to compose your own app structure.)
  2. Setup guard-rspec and terminal notification. (As this is setup Mac OS, terminal-notifier and terminal-notifier-guard are used. Use corresponding gems for non Mac OS setups.)
  3. Add passing examples.
  4. Then, add an example that will not yet fail/pass due to an error. Say you have an Arithmeter module and you wish to add Util module under it. Example:
require "spec_helper"

describe Arithmeter::Util do
  it "is true" do
    expect(true).to eq(true)
  end
end

Note: You can just clone this repo and just do last step (No. 4).

Current Behavior

After following recreate steps above:

  • There is a notification displayed but it is not for error.
  • It just notifies that there are 0 examples, 0 failures in x seconds, and
  • The icon implies that test is a success.

guard-rspec-current-notification

Expected Behavior

  • It should notify that there is an error and examples are not run.
  • It should not notify about number of examples and failures.
  • The icon should be of error type.

System configuration

  • ruby 2.3.3p222
  • guard-rspec (4.7.3)
  • guard (2.14.1)
  • rspec (3.6.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant