-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add circuit breaker #38
Comments
This is common practice at Netflix (see http://techblog.netflix.com/2011/12/making-netflix-api-more-resilient.html for example, but there's lots of stuff on their blogs). I think building it into the client, and having it turned on by default, makes the most sense. It'd help you in situations where you have too many requests to ElasticSearch, etc., queued up, or the web boxes are saturated. @tackley @philwills What do you guys think? |
Yup, this seems like exactly the kind of way that having a client library can add value. Having said that it should be obvious in docs and moan loudly when it fires. |
I am not sure what exactly a circuit breaker means on client side, but I agree the client should provide more values that just the raw API. I had 2 ideas in mind:
|
This explains the concept: http://martinfowler.com/bliki/CircuitBreaker.html |
@robertberry suggested adding a circuit breaker to the client to ensure good behaviour in the case of problems.
Let's discuss and if agreed, implement.
The text was updated successfully, but these errors were encountered: