Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get link component calculating its own text underline thickness from presets #1288

Open
oliverabrahams opened this issue Mar 18, 2024 · 4 comments
Assignees

Comments

@oliverabrahams
Copy link
Contributor

No description provided.

@jamesmockett
Copy link
Contributor

Akemi is reviewing the default values for underline thickness as it varies across browsers, and whether we can calculate this as a percentage to simplify our code and remove the need for the custom property in the presets.

@SiAdcock
Copy link
Contributor

@jamesmockett shall we chase Faye at the next DS/CSTI planning session?

@jamesmockett
Copy link
Contributor

@jamesmockett shall we chase Faye at the next DS/CSTI planning session?

Due to hack days there hasn't been a DS/CSTI planning session since the last CSTI one, but will chase this next week. We could simply close this ticket as there's nothing we urgently need to do here? This was more of a nice to have to clean up the code a little, but we can deal with it once the DS team have made a decision and ask us to update the underline styles. (The plan seems to be to remove the custom underline styles completely and use the browser defaults.)

@SiAdcock
Copy link
Contributor

SiAdcock commented Jun 13, 2024

@jamesmockett will prototype removing the custom styles in Storybook and show to Faye.

We should capture how this looks in different browsers using Browserstack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants