Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate US banner test tracking #12945

Open
domlander opened this issue Dec 4, 2024 · 2 comments · May be fixed by #12947
Open

Investigate US banner test tracking #12945

domlander opened this issue Dec 4, 2024 · 2 comments · May be fixed by #12947
Assignees

Comments

@domlander
Copy link
Contributor

domlander commented Dec 4, 2024

We have been seeing unexpected data from the US banner test. The number of closes and CTA clicks both exceed the number of expands. This should be impossible, since the component does not allow closes or CTA clicks until the component is expanded.

Snapshot of the data part way through the test, provided by Anthony from D&I
Image

@domlander domlander converted this from a draft issue Dec 4, 2024
@domlander domlander self-assigned this Dec 4, 2024
@domlander domlander added this to the Onward Journeys milestone Dec 4, 2024
@domlander
Copy link
Contributor Author

I looked into this with Jake from commercial. We discovered that the expand event is not being sent to Ophan when the component is expanded. This is most likely because the click is captured on a div element and ophan discounts these elements from tracking. We still have some clicks on the expands from the table, which is unexpected. This may have occurred due to certain browsers behaving differently or through dev testing.

@domlander
Copy link
Contributor Author

I changed the expand element from a div to a button, so that ophan can track the clicks. However, I notice that the request is not always sent to ophan, which is unexpected.

Screen.Recording.2024-12-02.at.16.13.15.mov

Ophan does have a submitComponentEvent function, which may be able to track the clicks instead

@domlander domlander linked a pull request Dec 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant