-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @guardian/source
package
#12063
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -19 kB (-2%) Total Size: 931 kB
ℹ️ View Unchanged
|
cemms1
force-pushed
the
cemms1/update-source-package
branch
from
August 2, 2024 17:01
0c8683f
to
98b2bad
Compare
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
cemms1
force-pushed
the
cemms1/update-source-package
branch
from
August 2, 2024 17:03
98b2bad
to
2baa832
Compare
sndrs
approved these changes
Aug 6, 2024
cemms1
force-pushed
the
cemms1/update-source-package
branch
from
August 6, 2024 11:13
2baa832
to
907dbfc
Compare
cemms1
force-pushed
the
cemms1/update-source-package
branch
from
August 6, 2024 12:08
907dbfc
to
b6c466e
Compare
Closed
Closed
cemms1
force-pushed
the
cemms1/update-source-package
branch
from
August 27, 2024 12:43
b6c466e
to
5c94ad8
Compare
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Aug 27, 2024
This was referenced Aug 27, 2024
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Bumps version of
source
from1.0.3
to6.1.0
.This is quite a large number of major versions to jump through so it might be worth breaking this up into smaller PRs potentially.
Summary of major changes
Fixes conflicting types between Emotion's deps, as outlined in emotion-js/emotion#3141.
guardian/csnx@d274436: Adds new icons to the icon library and applies updates to existing icons. In addition, some icons have been renamed and others deprecated. Icons that were previously deprecated have now been removed in this update.
Renamed icons
These icons have been renamed:
SvgBookMark
SvgBookmarkFilled
SvgBookMarkCross
SvgBookmarkCross
SvgCrossRound
SvgCrossRoundFilled
SvgHouse
SvgHomeHouseFilled
SvgPersonRound
SvgPersonRoundFilled
SvgShare
SvgShareWeb
Deprecated icons
These existing deprecated aliases have been removed:
SvgOfflineCloud
SvgCrossedOutCloud
SvgAlert
SvgExclamation
SvgMessenger
SvgFacebookMessenger
SvgInfo
SvgInfoRound
SvgPlay
SvgMediaControlsPlay
SvgPayPal
SvgPayPalBrand
eg. if you are importing
SvgOfflineCloud
this is aliased toSvgCrossedOutCloud
. The alias has now been removed so you should importSvgCrossedOutCloud
directly.The following icons have been deprecated and are still available, but will be removed in a future release:
SvgAlertTriangle
SvgAlertRound
SvgFilter
SvgFilterOutlinedWeb
SvgShareCallout
SvgShareWeb
There are some issues with peer dependencies both before and after this change, which might require addressing.
Why?
I'd like to use some newly released things from
source
but can't yet due to the DCR deps being behind.I'm happy to pair on this with someone