Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byline and Credit fields not using asciifolding #1997

Open
paperboyo opened this issue Sep 18, 2016 · 0 comments
Open

Byline and Credit fields not using asciifolding #1997

paperboyo opened this issue Sep 18, 2016 · 0 comments

Comments

@paperboyo
Copy link
Contributor

paperboyo commented Sep 18, 2016

Hello,

See related #1246. Usefully, one can search for "walesa" and find "wałęsa" (and vice versa) when the term is a part of the Description field.

Unfortunately, both Byline and Credit fields aren't working that way. Please compare:
https://[PROD]/search?query=donovan by:"Pål Hansen"
&
https://[PROD]/search?query=donovan by:"Pal Hansen"

Having ES asciifolding working for these two fields is more important than for Description and is a prerequisite to fixing inconsistencies and misspellings of photographer's names. But yes, we also need a way to opt out of this future default behaviour and search like today.

Regards
Mateusz

@sihil sihil added the To Review PRs that need to be reviewed label Sep 8, 2020
@paperboyo paperboyo added enhancement and removed To Review PRs that need to be reviewed labels Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants