From c76f122d7e584b2c6daaecf54e5f3b996203a40f Mon Sep 17 00:00:00 2001
From: Tom Forbes <tom.forbes@theguardian.com>
Date: Wed, 30 Oct 2024 15:25:34 +0000
Subject: [PATCH] only allow one method

---
 .../TestMethodologyEditor.tsx                 | 113 ++----------------
 .../bannerTests/bannerTestEditor.tsx          |   1 -
 .../epicTests/testEditor.tsx                  |   1 -
 3 files changed, 10 insertions(+), 105 deletions(-)

diff --git a/public/src/components/channelManagement/TestMethodologyEditor.tsx b/public/src/components/channelManagement/TestMethodologyEditor.tsx
index fa3143a0..a741cfc1 100644
--- a/public/src/components/channelManagement/TestMethodologyEditor.tsx
+++ b/public/src/components/channelManagement/TestMethodologyEditor.tsx
@@ -1,17 +1,7 @@
 import React from 'react';
 import { Methodology } from './helpers/shared';
 import { makeStyles } from '@mui/styles';
-import {
-  Button,
-  MenuItem,
-  Select,
-  SelectChangeEvent,
-  TextField,
-  Theme,
-  Tooltip,
-} from '@mui/material';
-import CloseIcon from '@mui/icons-material/Close';
-import AddIcon from '@mui/icons-material/Add';
+import { MenuItem, Select, SelectChangeEvent, TextField, Theme } from '@mui/material';
 
 const useStyles = makeStyles(({ spacing, palette }: Theme) => ({
   container: {
@@ -29,29 +19,6 @@ const useStyles = makeStyles(({ spacing, palette }: Theme) => ({
       marginLeft: spacing(1),
     },
   },
-  audiencePercentage: {
-    display: 'flex',
-    alignItems: 'center',
-    margin: `0 ${spacing(1)}`,
-    fontWeight: 500,
-  },
-  testNameAndDeleteButton: {
-    marginLeft: 'auto',
-    display: 'flex',
-    alignItems: 'center',
-  },
-  deleteButton: {
-    '& > button': {
-      height: '100%',
-    },
-  },
-  testName: {
-    marginRight: spacing(2),
-    fontWeight: 500,
-  },
-  error: {
-    color: 'red',
-  },
 }));
 
 const defaultEpsilonGreedyBandit: Methodology = {
@@ -59,30 +26,16 @@ const defaultEpsilonGreedyBandit: Methodology = {
   epsilon: 0.1,
 };
 
-const addMethodologyToTestName = (testName: string, methodology: Methodology): string => {
-  if (methodology.name === 'EpsilonGreedyBandit') {
-    return `${testName}_EpsilonGreedyBandit-${methodology.epsilon}`;
-  } else {
-    return `${testName}_ABTest`;
-  }
-};
-
 interface TestMethodologyProps {
   methodology: Methodology;
-  audiencePercentage: number;
-  testName?: string;
   isDisabled: boolean;
   onChange: (methodology: Methodology) => void;
-  onDelete: () => void;
 }
 
 const TestMethodology: React.FC<TestMethodologyProps> = ({
   methodology,
-  audiencePercentage,
-  testName,
   isDisabled,
   onChange,
-  onDelete,
 }: TestMethodologyProps) => {
   const classes = useStyles();
 
@@ -96,9 +49,6 @@ const TestMethodology: React.FC<TestMethodologyProps> = ({
   };
   return (
     <div className={classes.methodologyContainer}>
-      <Tooltip title={'Percentage of the audience in this methodology'}>
-        <div className={classes.audiencePercentage}>{audiencePercentage}%</div>
-      </Tooltip>
       <div>
         <Select value={methodology.name} onChange={onSelectChange}>
           <MenuItem value={'ABTest'} key={'ABTest'}>
@@ -126,78 +76,35 @@ const TestMethodology: React.FC<TestMethodologyProps> = ({
           </div>
         )}
       </div>
-      <div className={classes.testNameAndDeleteButton}>
-        {testName && (
-          <div className={classes.testName}>{addMethodologyToTestName(testName, methodology)}</div>
-        )}
-        <div className={classes.deleteButton}>
-          <Button onClick={onDelete} disabled={isDisabled} variant="outlined" size="medium">
-            <CloseIcon />
-          </Button>
-        </div>
-      </div>
     </div>
   );
 };
 
 interface TestMethodologyEditorProps {
   methodologies: Methodology[];
-  testName: string;
   onChange: (methodologies: Methodology[]) => void;
   isDisabled: boolean;
 }
 
 export const TestMethodologyEditor: React.FC<TestMethodologyEditorProps> = ({
   methodologies,
-  testName,
   onChange,
   isDisabled,
 }: TestMethodologyEditorProps) => {
   const classes = useStyles();
 
-  const onAddClick = () => {
-    onChange([...methodologies, { name: 'ABTest' }]);
-  };
+  // For now we only support one methodology
+  const methodology = methodologies[0] ?? { name: 'ABTest' };
 
   return (
     <div className={classes.container}>
-      {methodologies.length < 1 && (
-        <div className={classes.error}>At least one test methodology is required</div>
-      )}
-
-      {methodologies.map((method, idx) => (
-        <TestMethodology
-          key={`methodology-${idx}`}
-          methodology={method}
-          // Only need to display test names if more than one methodology
-          testName={methodologies.length > 1 ? testName : undefined}
-          audiencePercentage={Math.round(100 / methodologies.length)}
-          isDisabled={isDisabled}
-          onChange={updatedMethodology => {
-            const updatedMethodologies = [
-              ...methodologies.slice(0, idx),
-              updatedMethodology,
-              ...methodologies.slice(idx + 1),
-            ];
-            onChange(updatedMethodologies);
-          }}
-          onDelete={() => {
-            const updatedMethodologies = [
-              ...methodologies.slice(0, idx),
-              ...methodologies.slice(idx + 1),
-            ];
-            onChange(updatedMethodologies);
-          }}
-        />
-      ))}
-      <Button
-        onClick={onAddClick}
-        disabled={isDisabled || methodologies.length >= 4}
-        variant="outlined"
-        size="medium"
-      >
-        <AddIcon />
-      </Button>
+      <TestMethodology
+        methodology={methodology}
+        isDisabled={isDisabled}
+        onChange={updatedMethodology => {
+          onChange([updatedMethodology]);
+        }}
+      />
     </div>
   );
 };
diff --git a/public/src/components/channelManagement/bannerTests/bannerTestEditor.tsx b/public/src/components/channelManagement/bannerTests/bannerTestEditor.tsx
index 029969ef..04ba5b9b 100644
--- a/public/src/components/channelManagement/bannerTests/bannerTestEditor.tsx
+++ b/public/src/components/channelManagement/bannerTests/bannerTestEditor.tsx
@@ -240,7 +240,6 @@ const BannerTestEditor: React.FC<ValidatedTestEditorProps<BannerTest>> = ({
           </Typography>
           <TestMethodologyEditor
             methodologies={test.methodologies}
-            testName={test.name}
             isDisabled={!userHasTestLocked}
             onChange={onMethodologyChange}
           />
diff --git a/public/src/components/channelManagement/epicTests/testEditor.tsx b/public/src/components/channelManagement/epicTests/testEditor.tsx
index d4aac628..dd33b36a 100644
--- a/public/src/components/channelManagement/epicTests/testEditor.tsx
+++ b/public/src/components/channelManagement/epicTests/testEditor.tsx
@@ -265,7 +265,6 @@ export const getEpicTestEditor = (
           </Typography>
           <TestMethodologyEditor
             methodologies={test.methodologies}
-            testName={test.name}
             isDisabled={!userHasTestLocked}
             onChange={onMethodologyChange}
           />