Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove current_server from the configuration #1996

Closed
3 tasks
mssalvatore opened this issue Jun 8, 2022 · 0 comments · Fixed by #2017
Closed
3 tasks

Remove current_server from the configuration #1996

mssalvatore opened this issue Jun 8, 2022 · 0 comments · Fixed by #2017
Labels
Complexity: High Impact: Medium Refactor sp/3

Comments

@mssalvatore
Copy link
Collaborator

mssalvatore commented Jun 8, 2022 •
edited
Loading

Refactor

Component(s) to be refactored

  • configuration

Explanation

The agent's configuration includes an option called "current_server". This is not configuration information, but state.

Tasks

  • Remove the "current_server" option from the configuration. (0.25d) @ilija-lazoroski
    • Fix any agent code that relies on it
  • If any Island code relies on this value (attack report), find another way to get it. Perhaps add it to the agent model instead of the configuration. (0.25d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Complexity: High Impact: Medium Refactor sp/3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1996 island worm config decouple guardicore/monkey
2 participants
@ilija-lazoroski @mssalvatore