Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for manually uploaded config. #906

Closed
VakarisZ opened this issue Dec 15, 2020 · 6 comments · Fixed by #1970
Closed

Remove support for manually uploaded config. #906

VakarisZ opened this issue Dec 15, 2020 · 6 comments · Fixed by #1970

Comments

@VakarisZ
Copy link
Contributor

Describe the bug

There is an unmaintained(and probably unused) feature which allows users to provide configuration file path via cmd arguments.
I think this feature is heritage of days long gone and should be removed.

Changes to code:

Steps to reproduce the behavior:

  1. Remove config argument and related parsing
  2. Remove example config file
@acepace
Copy link
Contributor

acepace commented Dec 17, 2020

@VakarisZ are you talking about importing config in island or importing config in monkey?

In case of monkey, it is legacy and easy to remove.
However, this is a good mechanism to pass in initial commands to the monkey when it's dropped, besides just the island IP

@VakarisZ
Copy link
Contributor Author

AFAIK there's no cmd arguments for the island.
What kind on initial commands? Ideally, cmd arguments should only contain info to connect to the island

@acepace
Copy link
Contributor

acepace commented Dec 19, 2020

For example, specific tunnel

@VakarisZ
Copy link
Contributor Author

Tunnel is passed via cmd argument, not via config. Monkey either connects to the server and pulls the config or dies and config is not used. The only use case for manually specifying config is to manually run two monkeys on the network simultaneously with different configs. But until that's a real use case, this "feature" should be removed.

@acepace
Copy link
Contributor

acepace commented Dec 21, 2020

Right now it's also broken as the configuration gets overriden by the island anyway so easy deletion.

@mssalvatore
Copy link
Collaborator

See #244 for a use case of this capability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants