-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for manually uploaded config. #906
Comments
@VakarisZ are you talking about importing config in island or importing config in monkey? In case of monkey, it is legacy and easy to remove. |
AFAIK there's no cmd arguments for the island. |
For example, specific tunnel |
Tunnel is passed via cmd argument, not via config. Monkey either connects to the server and pulls the config or dies and config is not used. The only use case for manually specifying config is to manually run two monkeys on the network simultaneously with different configs. But until that's a real use case, this "feature" should be removed. |
Right now it's also broken as the configuration gets overriden by the island anyway so easy deletion. |
See #244 for a use case of this capability. |
Describe the bug
There is an unmaintained(and probably unused) feature which allows users to provide configuration file path via cmd arguments.
I think this feature is heritage of days long gone and should be removed.
Changes to code:
Steps to reproduce the behavior:
The text was updated successfully, but these errors were encountered: